Merged
Conversation
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
jflo
reviewed
Dec 17, 2024
Contributor
jflo
left a comment
There was a problem hiding this comment.
so far so good, possible bug in osaka setup.
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
| // * @param parentBlobGasUsed blob gas used from the parent | ||
| // * @return the new excess blob gas value | ||
| // */ | ||
| // default long computeExcessBlobGas( |
Contributor
There was a problem hiding this comment.
Assume this all gets deleted after coming out of draft
macfarla
reviewed
Dec 17, 2024
...e/src/main/java/org/hyperledger/besu/ethereum/mainnet/CancunTargetingGasLimitCalculator.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…or each fork This isolates defaulting to MainnetProtocolSpecs and reduces blast radius for tests Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
- Add asMap for blobSchedule so it appears in admin_nodeInfo - Prememptively add OsakaTargetingGasLimitCalculator and wire in the max blob count Add blobschedule to mainnet.json to be explicit, since the code will default to the same values anyway Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
macfarla
reviewed
Dec 19, 2024
config/src/main/java/org/hyperledger/besu/config/BlobScheduleOptions.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/hyperledger/besu/ethereum/mainnet/OsakaTargetingGasLimitCalculator.java
Outdated
Show resolved
Hide resolved
…net/OsakaTargetingGasLimitCalculator.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
daniellehrner
approved these changes
Dec 19, 2024
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
garyschulte
pushed a commit
that referenced
this pull request
Dec 20, 2024
Drive Cancun, Prague and Osaka target and max blobs per block from genesis config. If blobSchedule is missing, use the mainnet default values. Target is wired into appropriate *GasCalculator implementations. Max is wired into appropriate *TargetingGasLimitCalculator implementations. --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
Drive Cancun, Prague and Osaka target and max blobs per block from genesis config. If blobSchedule is missing, use the mainnet default values. Target is wired into appropriate *GasCalculator implementations. Max is wired into appropriate *TargetingGasLimitCalculator implementations. --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Drive Cancun, Prague and Osaka target and max blobs per block from genesis config:
If blobSchedule is missing, use the mainnet default values, i.e. same as config above.
Target is wired into appropriate *GasCalculator implementations
Max is wired into appropriate *TargetingGasLimitCalculator implementations
This PR does not remove EIP-7742 (although overlaps slightly)
This has been tested with a local pectra interop and successfully produced and validated blocks containing up to 9 blobs.
2024-12-19 02:42:22.551+00:00 | vert.x-worker-thread-0 | INFO | AbstractEngineNewPayload | Imported #34 (8c3c2.....3c8e7)| 58 tx| 0 ws| 9 blobs| base fee 17.89 mwei| gas used 2,390,426 ( 8.0%)| exec time 0.010s| mgas/s 239.04| peers: 2Fixed Issue(s)
#8026
ethereum/EIPs#9129
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests